fix: bug#2432 Filter options sorted alphabetically #2538

Arslan-Muhammad · 2024-10-22T18:27:52Z

What does this PR do?

This PR will fix Filter options and sorted them alphabetically.

Fixes #2432

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

No need of any test just test by locally run project

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

Summary by CodeRabbit

New Features
- Introduced alphabetical sorting for displayed languages and frameworks, enhancing user experience.

changeset-bot · 2024-10-22T18:27:57Z

⚠️ No Changeset found

Latest commit: 81aaa53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CLAassistant · 2024-10-22T18:28:00Z

All committers have signed the CLA.

vercel · 2024-10-22T18:28:02Z

@Arslan-Muhammad is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-10-22T18:28:02Z

📝 Walkthrough

Walkthrough

The changes in the pull request focus on the TemplatesClient component located in apps/www/app/templates/client.tsx. Modifications include the addition of a sorting mechanism for both the languages and frameworks sections, which are now sorted alphabetically before rendering. The overall structure and logic of the component remain unchanged, with no alterations to existing functionality. The rendering of FormField components has been updated to accommodate the new sorting logic while maintaining the handling of checkbox states.

Changes

File	Change Summary
apps/www/app/templates/client.tsx	Added alphabetical sorting for the `languages` and `frameworks` sections in the filtering logic. Reformatted rendering of `FormField` components for both languages and frameworks.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TemplatesClient
    participant FormField

    User->>TemplatesClient: Request templates
    TemplatesClient->>TemplatesClient: Process languages and frameworks
    TemplatesClient->>FormField: Render FormField for languages
    TemplatesClient->>FormField: Render FormField for frameworks
    FormField-->>TemplatesClient: Return rendered fields
    TemplatesClient-->>User: Display templates

Assessment against linked issues

Objective	Addressed	Explanation
Filter options should be sorted alphabetically (#2432)	✅

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb4d3e and 81aaa53.

📒 Files selected for processing (1)

apps/www/app/templates/client.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/www/app/templates/client.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-10-22T18:28:08Z

Thank you for following the naming conventions for pull request titles! 🙏

vercel · 2024-10-22T18:29:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 4:39pm
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 4:39pm
play	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 4:39pm
workflows	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 4:39pm
www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 4:39pm

chronark · 2024-10-28T13:19:50Z

please sign the CLA

Arslan-Muhammad · 2024-10-29T07:32:56Z

please sign the CLA

CLA Signed.

Arslan-Muhammad · 2024-11-05T04:35:27Z

@chronark
Please approve this PR or type any suggestion regarding PR.

chronark · 2024-11-07T10:53:33Z

this only works for frameworks, not languages

Arslan-Muhammad · 2024-11-07T16:50:48Z

this only works for frameworks, not languages

@chronark
Please check, now working for both frameworks and languages.
Screenshot also updated.

fixed bug#2432 Filter options sorted alphabetically

debfbfc

Arslan-Muhammad requested review from perkinsjr, chronark, MichaelUnkey and mcstepp as code owners October 22, 2024 18:27

vercel bot deployed to Preview – engineering October 22, 2024 18:29 View deployment

Arslan-Muhammad changed the title ~~fixed bug#2432 Filter options sorted alphabetically~~ fix: bug#2432 Filter options sorted alphabetically Oct 22, 2024

[autofix.ci] apply automated fixes

2bb4d3e

vercel bot deployed to Preview – engineering October 28, 2024 13:19 View deployment

chronark added the Requires CLA Waiting for a contributor to sign the CLA label Oct 28, 2024

vercel bot deployed to Preview – play October 29, 2024 12:00 View deployment

vercel bot deployed to Preview – workflows October 29, 2024 12:01 View deployment

vercel bot deployed to Preview – dashboard October 29, 2024 12:03 View deployment

vercel bot deployed to Preview – www October 29, 2024 12:04 View deployment

languages sorted alphabetically

81aaa53

vercel bot deployed to Preview – engineering November 7, 2024 16:39 View deployment

chronark merged commit fff18df into unkeyed:main Nov 13, 2024
7 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: bug#2432 Filter options sorted alphabetically #2538

fix: bug#2432 Filter options sorted alphabetically #2538

Arslan-Muhammad commented Oct 22, 2024 •

edited

Loading

changeset-bot bot commented Oct 22, 2024 •

edited

Loading

CLAassistant commented Oct 22, 2024 •

edited

Loading

vercel bot commented Oct 22, 2024

coderabbitai bot commented Oct 22, 2024 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Oct 22, 2024 •

edited

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading

chronark commented Oct 28, 2024

Arslan-Muhammad commented Oct 29, 2024

Arslan-Muhammad commented Nov 5, 2024 •

edited

Loading

chronark commented Nov 7, 2024

Arslan-Muhammad commented Nov 7, 2024 •

edited

Loading

fix: bug#2432 Filter options sorted alphabetically #2538

fix: bug#2432 Filter options sorted alphabetically #2538

Conversation

Arslan-Muhammad commented Oct 22, 2024 • edited Loading

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Summary by CodeRabbit

changeset-bot bot commented Oct 22, 2024 • edited Loading

⚠️ No Changeset found

CLAassistant commented Oct 22, 2024 • edited Loading

vercel bot commented Oct 22, 2024

coderabbitai bot commented Oct 22, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Oct 22, 2024 • edited Loading

vercel bot commented Oct 22, 2024 • edited Loading

chronark commented Oct 28, 2024

Arslan-Muhammad commented Oct 29, 2024

Arslan-Muhammad commented Nov 5, 2024 • edited Loading

chronark commented Nov 7, 2024

Arslan-Muhammad commented Nov 7, 2024 • edited Loading

Arslan-Muhammad commented Oct 22, 2024 •

edited

Loading

changeset-bot bot commented Oct 22, 2024 •

edited

Loading

CLAassistant commented Oct 22, 2024 •

edited

Loading

coderabbitai bot commented Oct 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Oct 22, 2024 •

edited

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading

Arslan-Muhammad commented Nov 5, 2024 •

edited

Loading

Arslan-Muhammad commented Nov 7, 2024 •

edited

Loading