3456 Golang changes #255
Open
3456 Golang changes #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveen-gowda-arista
requested review from
jsommerville-untangle
and removed request for
jsommerville-untangle
| @@ -0,0 +1,58 @@ | |||
| package quota | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
instead of adding new structures for all of these, we can reuse the policy manager object structures:
this will simplify policy manager integration as well
|
|
||
| type QuotaExceedActions struct { | ||
| ID string `json:"id"` | ||
| Name string `json:name` |
There was a problem hiding this comment.
Typo - need double quotes around name
There was a problem hiding this comment.
HI @AlistairJohnParker , This code is no more used. We have moved this module to sync settings. Will talk to John S and invalidate this branch. Please ignore this for now. Thanks for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review