Merge pull request #126 from unyt-org/pointer-fixes

Pointer Fixes
unyt-org · Jul 17, 2024 · bb6be81 · bb6be81
2 parents c11c4e5 + e7ed3ff
commit bb6be81
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/runtime/pointers.ts b/runtime/pointers.ts
@@ -3887,7 +3887,12 @@ export class Pointer<T = any> extends Ref<T> {
                     if (is_array && Number(prop)+1==obj.length) Runtime.runtime_actions.trimArray(obj)
 
                     return true
-                }
+                },
+                ownKeys: (target) => {
+                    // assume that the whole object should be observed for transform
+                    this.handleBeforeNonReferencableGet();
+                    return Reflect.ownKeys(target);
+                },
             });
 
             // set right 'this' context for getters / setters

diff --git a/types/native_types.ts b/types/native_types.ts
@@ -181,15 +181,17 @@ Type.std.Set.setJSInterface({
     create_proxy: (value:Set<any>, pointer:Pointer) => {
         // override methods
         Object.defineProperty(value, "add", {value: el => {
-                return pointer.handleAdd(el);
+                if (value.has(el)) return false;
+                return pointer.handleAdd(el); // TODO: return the Set
             }, writable:false, enumerable:false});
 
         Object.defineProperty(value, "clear", {value: () => {
                 return pointer.handleClear();
             }, writable:false, enumerable:false});
 
         Object.defineProperty(value, "delete", {value: el => {
-                return pointer.handleRemove(el);
+                if (!value.has(el)) return false;
+                return pointer.handleRemove(el); // TODO: return the Set
             }, writable:false, enumerable:false});
 
         /**** override getters to trigger handleBeforeValueGet(): ****/