fix: 결제 상태 확인 로직 수정

- payments 전체가 SUCCESS인 경우만 결제 완료로 처리하던 로직을 수정 - 하나의 payment라도 SUCCESS인 경우 결제 완료로 처리하도록 변경
uoslife · Dec 6, 2024 · f916a28 · f916a28
1 parent 0859112
commit f916a28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/main/kotlin/uoslife/servermeeting/match/dao/MatchedDao.kt b/src/main/kotlin/uoslife/servermeeting/match/dao/MatchedDao.kt
@@ -50,8 +50,7 @@ class MatchedDao(private val queryFactory: JPAQueryFactory) {
                 .mapValues { (_, userTeams) ->
                     userTeams.all { userTeam ->
                         val payments = userTeam.team.payments
-                        payments?.isNotEmpty() == true &&
-                            payments.all { it.status == PaymentStatus.SUCCESS }
+                        payments?.any { it.status == PaymentStatus.SUCCESS } ?: false
                     }
                 }
 

diff --git a/src/main/kotlin/uoslife/servermeeting/match/service/MatchingService.kt b/src/main/kotlin/uoslife/servermeeting/match/service/MatchingService.kt
@@ -49,10 +49,10 @@ class MatchingService(
                 ?: throw MeetingTeamNotFoundException()
         val meetingTeam = userTeam.team
 
-        val hasInvalidPayment =
-            meetingTeam.payments?.any { payment -> payment.status != PaymentStatus.SUCCESS }
+        val hasValidPayment =
+            meetingTeam.payments?.any { payment -> payment.status == PaymentStatus.SUCCESS }
                 ?: false
-        if (hasInvalidPayment) {
+        if (!hasValidPayment) {
             throw PaymentNotFoundException()
         }