Skip to content

Commit

Permalink
Merge pull request #23 from ytsarev/yamllint
Browse files Browse the repository at this point in the history
Setup yamllint
  • Loading branch information
ytsarev authored Jan 4, 2024
2 parents d488813 + bf31fb5 commit 567b81d
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 7 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/yamllint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: yamllint
on: [pull_request]
jobs:
yamllint:
name: runner / yamllint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: yamllint
uses: reviewdog/action-yamllint@v1.9.0
with:
reporter: github-pr-review
filter_mode: nofilter
yamllint_flags: 'apis/'
fail_on_error: true
5 changes: 5 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
extends: default

rules:
line-length: disable
document-start: disable
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,9 @@ e2e: build controlplane.up local.xpkg.deploy.configuration.$(PROJECT_NAME) uptes
render:
crossplane beta render examples/network-xr.yaml apis/basic/composition.yaml examples/function/function.yaml -r

.PHONY: uptest e2e render
yamllint:
@$(INFO) running yamllint
@yamllint ./apis || $(FAIL)
@$(OK) running yamllint

.PHONY: uptest e2e render yamllint
12 changes: 6 additions & 6 deletions apis/definition.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@ spec:
deletionPolicy:
description: Delete the external resources when the Claim/XR is deleted. Defaults to Delete
enum:
- Delete
- Orphan
- Delete
- Orphan
type: string
default: Delete
providerConfigName:
description: Crossplane ProviderConfig to use for provisioning this resources
type: string
default: default
required:
- deletionPolicy
- providerConfigName
- id
- region
- deletionPolicy
- providerConfigName
- id
- region
type: object
required:
- parameters
Expand Down

0 comments on commit 567b81d

Please sign in to comment.