Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup yamllint #23

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Setup yamllint #23

merged 2 commits into from
Jan 4, 2024

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Jan 4, 2024

Description of your changes

Setup yaml lint for consistent yaml formating across the Configuration according to agreed best practices.

  • config
  • make target
  • github action

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Before definition.yaml fixes

make yamllint
09:03:34 [ .. ] running yamllint
./apis/definition.yaml
  33:23     error    wrong indentation: expected 24 but found 22  (indentation)
  42:19     error    wrong indentation: expected 20 but found 18  (indentation)

09:03:34 [FAIL]
make: *** [Makefile:80: yamllint] Error 1
image

@ytsarev ytsarev requested a review from a team January 4, 2024 08:07
@ytsarev ytsarev force-pushed the yamllint branch 7 times, most recently from 0bb09dc to 76d3f28 Compare January 4, 2024 08:37
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

@haarchri yamllint GHA doesn't fail for some reason, meanwhile, it should. I am investigating...

* config
* make target
* github action

Signed-off-by: Yury Tsarev <yury@upbound.io>
Signed-off-by: Yury Tsarev <yury@upbound.io>
@ytsarev ytsarev requested a review from haarchri January 4, 2024 09:15
@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

@haarchri ok, it was filter_mode: nofilter parameter for review_dog. I switched it to be global for apis in sync to the standard make target to avoid confusion. Please review again

@ytsarev
Copy link
Member Author

ytsarev commented Jan 4, 2024

/test-examples

@ytsarev ytsarev merged commit 567b81d into upbound:main Jan 4, 2024
2 checks passed
@ytsarev ytsarev deleted the yamllint branch January 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants