Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(file-uploader): Updated @uploadcare/blocks to @uploadcare/file-u… #296

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(file-uploader): Updated @uploadcare/blocks to @uploadcare/file-u… #296

wants to merge 3 commits into from

Conversation

egordidenko
Copy link

…ploader

Description

Checklist

rsedykh
rsedykh reviewed Aug 18, 2024
View reviewed changes
pyuploadcare/dj/conf.py Outdated Show resolved Hide resolved
dmitry-mukhin
dmitry-mukhin requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@dmitry-mukhin dmitry-mukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add changelog entry and we need new major pyuploadcare version.

@evgkirov
Copy link
Collaborator

Integration tests are failing.

@egordidenko
Copy link
Author

egordidenko commented Sep 19, 2024 •
edited
Loading

Integration tests are failing.

Unfortunately, yes. Do I need to fix them?
However, I checked on the main branch and it also fails the integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedykh rsedykh rsedykh left review comments

@evgkirov evgkirov evgkirov approved these changes

@dmitry-mukhin dmitry-mukhin Awaiting requested review from dmitry-mukhin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@egordidenko @evgkirov @rsedykh @dmitry-mukhin