Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More release-please fixes #89

Merged

Conversation

mdesouky
Copy link
Collaborator

Changes:

  • Fix initial version of CLI
  • Update appVersion in helm chart with new server releases

@@ -17,7 +17,8 @@
"extra-files": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just exclude the helm charts for updates to gitops serer.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it first, if it doesn't work, then sure.

Copy link
Collaborator

@uptickmetachu uptickmetachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for flow. You can also run release-please locally if you generate a GITHUB_TOKEN.

@mdesouky
Copy link
Collaborator Author

Approving for flow. You can also run release-please locally if you generate a GITHUB_TOKEN.

@uptickmetachu I'll try running it locally first then, if it does what it's supposed to, I'll merge.

@mdesouky mdesouky merged commit 9b1b92f into develop Nov 15, 2024
2 checks passed
@mdesouky mdesouky deleted the dev-930/automate-gitops-releases-with-release-please branch November 15, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants