Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added vars to class before init in uniprot classes #143

Merged
merged 1 commit into from
Jun 25, 2024
Merged

added vars to class before init in uniprot classes #143

merged 1 commit into from
Jun 25, 2024

Conversation

SamCox822
Copy link
Contributor

bug fix

@SamCox822
Copy link
Contributor Author

the bug seems unrelated? @Jgmedina95 can you take a look & we can do it in another PR

@Jgmedina95
Copy link
Contributor

It is a deprecation, simply 1.14 changed .simps to .simpson:
DeprecationWarning: 'scipy.integrate.simps' is deprecated in favour of 'scipy.integrate.simpson' and will be removed in SciPy 1.14.0
I'll change the function, and pin spicy version :)

@Jgmedina95
Copy link
Contributor

Solving with PR #144

Jgmedina95
Jgmedina95 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Jgmedina95 Jgmedina95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamCox822 SamCox822 merged commit f91db15 into main Jun 25, 2024
1 check failed
@SamCox822 SamCox822 deleted the class-init-bug-uniprot branch June 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jgmedina95 Jgmedina95 Jgmedina95 approved these changes

@brittyscience brittyscience Awaiting requested review from brittyscience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamCox822 @Jgmedina95