Release 2.0.0 #13
Merged
Release 2.0.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlepinski
commented
Jul 2, 2024
| path: "ios/Plugin" | ||
| ), | ||
| .target( | ||
| name: "UaCapacitorAirship", |
There was a problem hiding this comment.
SPM you cant have mixed source targets so I had to break this up into its own file to do the bootloader
rlepinski
commented
Jul 2, 2024
| } | ||
|
|
||
| override fun createConfigBuilder(context: Context): AirshipConfigOptions.Builder { | ||
| val pluginConfig = CapConfig.loadDefault(context).getPluginConfiguration("Airship") | ||
| val proxyConfig = ProxyConfig(JsonValue.wrapOpt(pluginConfig.getObject("config")).optMap()) | ||
| val builder = AirshipConfigOptions.newBuilder().applyDefaultProperties(context) | ||
| val builder = AirshipConfigOptions.newBuilder() | ||
| try { builder.tryApplyDefaultProperties(context) } catch (_: Exception) {} |
There was a problem hiding this comment.
Prevents logging that it cant find the config
rlepinski
commented
Jul 2, 2024
| #else | ||
| #import <Capacitor/ | ||
| #import "UACapacitorAirship-Swift.h" | ||
| @import UaCapacitorAirshipPlugin; |
rlepinski
commented
Jul 2, 2024
| proxy.push.isNotificationChannelEnabled(arg.requireString()) | ||
| } else { | ||
| true | ||
| scope.launch { |
There was a problem hiding this comment.
Same as before, I just moved this to be launched in the scope so its called on the main thread
crow
approved these changes
Jul 2, 2024
jyaganeh
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for Capacitor 6.
I tested SPM support but ran into this issue with a hardcoded ios 13 platform version. I created a feature request to make it configurable - ionic-team/capacitor#7544
Modifying the template I was able to verify the plugin works with SPM and Pods