-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Several Basic and Advanced Settings, Event logs, Last Unlock User #59
Conversation
Using commit hashes works just fine.
And the dev builds are failing because the dev branch is still behind. I changed the lib reference to the base repo and added the last commit hash as branch for the main build and in readme. With this change you don't have to maintain two repos anymore and still have reference to a specific version of the code. |
9bf81e3
to
445290a
Compare
445290a
to
edb249b
Compare
|
Ah okay, well... so lets do this for actions and still use yours for the Readme part.
Maybe thats caused by the more frequent request of the config after each status update.
There is probably a better way to achieve this by waiting for a period of time and then check again.
I added all the nee Entites there and also mentioned the Events part. Or did u mean smth else? |
I didn't save the logs so I can't tell for now. I follow and update.
AFAIK ESPHome is asynchronous, and to achieve this behavior you have to use set_timeout
I think just how to see the logs is missing |
Okay lets see what happens.
Ahh okay uhm the logs are just sent to homeassistant as events. I thought thats covering the logs already.
I will check a few options to see if they solve the delay issue. |
Do you mean it disconnected for an hour or after a long period? |
Yes. |
I thought about setting a timeout period in the loop and executing it when the time is up. For auth data and event logs. Also maybe change the way data is requested and not requesting on every status change but independently. |
Why not to use set_timeout instead?
You can do that, but just make sure that the status is updated whenever it is changed from the app/manually. |
Yea I just mean the config, advanced config and auth data + event logs because that's time consuming to request all of that after each other. I never used set_timeout, how does it work? |
I don't have much knowledge about set_timeout, but in the discord there's some explanation: |
d7eee26
to
6239b62
Compare
Do you think it's really necessary to request the auth data everytime or is every second time fine as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AzonInc!
Looks good. I also added you a collaborator (anyway, a large portion of the code is yours now :) )
This PR adds several basic and advanced settings entites as well as event support.
Switch:
Text Sensor:
Select:
Number:
Events:
Lock events are sent to Home Assistant with the esphome.nuki identifier by default.