Skip to content

Commit

Permalink
address code smel
Browse files Browse the repository at this point in the history
  • Loading branch information
dan-du-car committed Apr 16, 2024
1 parent f671c8d commit 036a992
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace RSUHealthMonitor
return root;
}

void RSUConfigurationList::parseRSUs(const std::string &rsuConfigsStr)
void RSUConfigurationList::parseRSUs(std::string &rsuConfigsStr)
{
auto json = parseJson(rsuConfigsStr);
std::vector<RSUConfiguration> tempConfigs;
Expand Down Expand Up @@ -84,7 +84,7 @@ namespace RSUHealthMonitor
configs.assign(tempConfigs.begin(), tempConfigs.end());
}

RSUMibVersion RSUConfigurationList::strToMibVersion(const std::string &mibVersionStr) const
RSUMibVersion RSUConfigurationList::strToMibVersion(std::string &mibVersionStr) const
{
boost::trim_left(mibVersionStr);
boost::trim_right(mibVersionStr);
Expand Down
4 changes: 2 additions & 2 deletions src/v2i-hub/RSUHealthMonitorPlugin/src/RSUConfigurationList.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ namespace RSUHealthMonitor
* @return JSON::Value A JSON object that includes RSUS information.
*/
Json::Value parseJson(const std::string &rsuConfigsStr) const;
RSUMibVersion strToMibVersion(const std::string &mibVersionStr) const;
RSUMibVersion strToMibVersion(std::string &mibVersionStr) const;

public:
RSUConfigurationList() = default;
Expand All @@ -55,7 +55,7 @@ namespace RSUHealthMonitor
* @brief Parse RSUs configrations in JSON string representation, and update the memeber of list of RSUConfiguration struct.
* @param rsuConfigsStr A JSON string includes all RSUs related configrations.
*/
void parseRSUs(const std::string &rsuConfigsStr);
void parseRSUs(std::string &rsuConfigsStr);
/**
* @brief Get a list of RSUConfiguration struct.
*/
Expand Down

0 comments on commit 036a992

Please sign in to comment.