update source

usdot-fhwa-OPS · Nov 9, 2023 · 1edaf32 · 1edaf32
1 parent c0bac10
commit 1edaf32
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUHealthMonitorPlugin.cpp b/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUHealthMonitorPlugin.cpp
@@ -9,7 +9,7 @@ namespace RSUHealthMonitor
     RSUHealthMonitorPlugin::RSUHealthMonitorPlugin(std::string name) : PluginClient(name)
     {
         UpdateConfigSettings();
-        // Send SNMP call to RSU status at configurable interval.
+        // Send SNMP call to RSU periodically at configurable interval.
         std::thread rsuStatus_t(&RSUHealthMonitorPlugin::PeriodicRSUStatusReq, this);
         rsuStatus_t.join();
     }
@@ -62,7 +62,7 @@ namespace RSUHealthMonitor
         }
         catch (const std::exception &e)
         {
-            PLOG(logERROR) << "Error updating RSU OID config" << e.what();
+            PLOG(logERROR) << "Error updating RSU OID config " << e.what();
         }
     }
 
@@ -75,12 +75,12 @@ namespace RSUHealthMonitor
     void RSUHealthMonitorPlugin::PeriodicRSUStatusReq()
     {
         while (true)
-        {
-            // Broadcast the RSU status info when there are any RSU responses.
+        {            
             try
             {
+                //SNMP call to get RSU status
                 auto rsuStatusJson = getRSUstatus();
-
+                // Broadcast the RSU status info when there are RSU responses.
                 if (!rsuStatusJson.empty())
                 {
                     vector<string> rsuStatusFields;
@@ -95,7 +95,8 @@ namespace RSUHealthMonitor
                         string json_str = fasterWirter.write(rsuStatusJson);
                         tmx::messages::RSUStatusMessage sendRsuStatusMsg;
                         sendRsuStatusMsg.set_contents(json_str);
-                        BroadcastMessage(sendRsuStatusMsg);
+                        string source = RSUHealthMonitorPlugin::GetName();
+                        BroadcastMessage(sendRsuStatusMsg, source);
                         PLOG(logINFO) << "Broadcast RSU status:  " << json_str;
                     }
                 }

diff --git a/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUHealthMonitorPlugin.h b/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUHealthMonitorPlugin.h
@@ -50,7 +50,7 @@ namespace RSUHealthMonitor
          */
         void PeriodicRSUStatusReq();
         /**
-         * @brief Sending SNMP requests to get info for each field in the _rsuOIDConfigMap, and return the RSU status in JSON string
+         * @brief Sending SNMP requests to get info for each field in the _rsuOIDConfigMap, and return the RSU status in JSON
          */
         Json::Value getRSUstatus();
         /**
@@ -61,6 +61,7 @@ namespace RSUHealthMonitor
         std::map<double, double> ParseGPS(const std::string &gps_nmea_data);
         /**
          * @brief determine if all required fields in the RSU config map _rsuOIDConfigMap present in the input fields
+         * @return True if all required fields found. Otherwise, false.
          */
         bool isAllRequiredFieldsPresent(vector<string> fields);