address code smell

usdot-fhwa-OPS · Apr 16, 2024 · 5a0dbca · 5a0dbca
1 parent 036a992
commit 5a0dbca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUConfigurationList.cpp b/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUConfigurationList.cpp
@@ -19,7 +19,7 @@ namespace RSUHealthMonitor
         return root;
     }
 
-    void RSUConfigurationList::parseRSUs(std::string &rsuConfigsStr)
+    void RSUConfigurationList::parseRSUs(const std::string &rsuConfigsStr)
     {
         auto json = parseJson(rsuConfigsStr);
         std::vector<RSUConfiguration> tempConfigs;
@@ -70,8 +70,8 @@ namespace RSUHealthMonitor
 
             if (rsuArray[i].isMember(RSUMIBVersionKey))
             {
-                auto _rsuMIBVersionStr = rsuArray[i][RSUMIBVersionKey].asString();
-                config.mibVersion = strToMibVersion(_rsuMIBVersionStr);
+                auto rsuMIBVersionStr = rsuArray[i][RSUMIBVersionKey].asString();
+                config.mibVersion = strToMibVersion(rsuMIBVersionStr);
             }
             else
             {

diff --git a/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUConfigurationList.h b/src/v2i-hub/RSUHealthMonitorPlugin/src/RSUConfigurationList.h
@@ -55,7 +55,7 @@ namespace RSUHealthMonitor
          * @brief Parse RSUs configrations in JSON string representation, and update the memeber of list of RSUConfiguration struct.
          * @param rsuConfigsStr A JSON string includes all RSUs related configrations.
          */
-        void parseRSUs(std::string &rsuConfigsStr);
+        void parseRSUs(const std::string &rsuConfigsStr);
         /**
          * @brief Get a list of RSUConfiguration struct.
          */