Skip to content

Commit

Permalink
Addressed sonar scanner code smells
Browse files Browse the repository at this point in the history
+Rule of 5 for Kafka consumer and producer
+ Remove virtual destructor for CARMAStreetsPlugin
  • Loading branch information
paulbourelly999 committed Jul 17, 2023
1 parent 07c3533 commit 6e611fb
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 6 deletions.
7 changes: 6 additions & 1 deletion src/tmx/TmxUtils/src/kafka/kafka_consumer_worker.h
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ namespace tmx::utils {
*
*/
~kafka_consumer_worker();

kafka_consumer_worker(kafka_consumer_worker& other) = delete;
kafka_consumer_worker& operator=(const kafka_consumer_worker& other) = delete;
kafka_consumer_worker(kafka_consumer_worker &&consumer) = delete;
kafka_consumer_worker const & operator=(kafka_consumer_worker &&consumer) = delete;
/**
* @brief Initialize kafka_consumer_worker
*
Expand All @@ -94,7 +99,7 @@ namespace tmx::utils {
/**
* @brief Stop running kafka consumer.
*/
virtual void stop();
void stop();
/**
* @brief Print current configurations.
*/
Expand Down
7 changes: 6 additions & 1 deletion src/tmx/TmxUtils/src/kafka/kafka_producer_worker.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ namespace tmx::utils
explicit kafka_producer_worker(const std::string &brokers);

virtual ~kafka_producer_worker();

kafka_producer_worker(kafka_producer_worker& other) = delete;
kafka_producer_worker& operator=(const kafka_producer_worker& other) = delete;
kafka_producer_worker(kafka_producer_worker &&producer) = delete;
kafka_producer_worker const & operator=(kafka_producer_worker &&producer) = delete;
/**
* @brief Initialize kafka_producer_worker. This method must be called before send!
*
Expand Down Expand Up @@ -102,7 +107,7 @@ namespace tmx::utils
/**
* @brief Stop running kafka producer.
*/
virtual void stop();
void stop();
/**
* @brief Print current configurations.
*/
Expand Down
1 change: 0 additions & 1 deletion src/tmx/TmxUtils/src/kafka/mock_kafka_consumer_worker.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ namespace tmx::utils {
MOCK_METHOD(bool, init,(),(override));
MOCK_METHOD(const char*, consume, (int timeout_ms), (override));
MOCK_METHOD(void, subscribe, (), (override));
MOCK_METHOD(void, stop, (), (override));
MOCK_METHOD(void, printCurrConf, (), (override));
MOCK_METHOD(bool, is_running, (), (const override));
};
Expand Down
1 change: 0 additions & 1 deletion src/tmx/TmxUtils/src/kafka/mock_kafka_producer_worker.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace tmx::utils {
MOCK_METHOD(bool, init,(),(override));
MOCK_METHOD(void, send, (const std::string &msg), (override));
MOCK_METHOD(bool, is_running, (), (const, override));
MOCK_METHOD(void, stop, (), (override));
MOCK_METHOD(void, printCurrConf, (), (override));
};
}
1 change: 0 additions & 1 deletion src/tmx/TmxUtils/test/KafkaTestEnvironment.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ class KafkaTestEnvironment : public ::testing::Environment {
else {
std::cout << "All Objects are destroyed!" << std::endl;
}

}
};
1 change: 0 additions & 1 deletion src/v2i-hub/CARMAStreetsPlugin/src/CARMAStreetsPlugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ namespace CARMAStreetsPlugin {
class CARMAStreetsPlugin: public PluginClientClockAware {
public:
CARMAStreetsPlugin(std::string);
virtual ~CARMAStreetsPlugin() = default ;
int Main();
protected:

Expand Down

0 comments on commit 6e611fb

Please sign in to comment.