Skip to content

Commit

Permalink
CXC-28: Update CARMA Cloud Plugin to have configurable IP/Port (#593)
Browse files Browse the repository at this point in the history
<!-- Thanks for the contribution, this is awesome. -->

# PR Details
## Description
Update CARMA Cloud plugin to allow for configurable target IP/Port for
sending CARMA Cloud REST Requests

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/46f850ea-5a4d-4796-8487-101bfb750ab5)

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/2d96c045-748c-435b-a1a2-d9febe438905)

**NOTE**: Large changeset is due to correcting line ending characters
for file. Feel free to double check change set in text diff tool of your
choice. Here is what I got

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/7ee70ee2-d952-4ec7-93fe-5bc86eb05ca5)

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/2d8ea908-765d-410d-8b36-5fec0378b199)

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/cdc71fdd-494e-4590-8e5b-dd54ff6f833f)

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/89af2000-79b0-4c5e-9a05-a6ffbc8bccdf)

![image](https://github.com/usdot-fhwa-OPS/V2X-Hub/assets/77466294/80b6cfb7-82e2-42ae-b63b-c0e314e31c5d)

<!--- Describe your changes in detail -->

## Related Issue
[CXC-28](https://usdot-carma.atlassian.net/browse/CXC-28)
<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context
To support CARMA Cloud CDASim Integration testing
<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?
Locally integration tested using devcontainer to ensure configurable
parameters were available and modified URL correctly
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Defect fix (non-breaking change that fixes an issue)
- [ ] New feature (non-breaking change that adds functionality)
- [ ] Breaking change (fix or feature that cause existing functionality
to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] I have added any new packages to the sonar-scanner.properties file
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
[V2XHUB Contributing
Guide](https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/develop/Contributing.md)
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
  • Loading branch information
paulbourelly999 authored Apr 4, 2024
1 parent 24d6989 commit 9ac6eda
Show file tree
Hide file tree
Showing 3 changed files with 673 additions and 659 deletions.
20 changes: 15 additions & 5 deletions src/v2i-hub/CARMACloudPlugin/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@
"default":"127.0.0.1",
"description":"Server IP address for V2X hub"
},
{
"key":"WebServicePort",
"default":"22222",
"description":"Server Port for V2X hub to receive TCM messages"
},
{
"key":"CARMACloudIP",
"default":"http://127.0.0.1",
"description":"Server IP address for V2X hub"
},
{
"key":"CARMACloudPort",
"default":"33333",
"description":"Server Port for V2X hub to receive TCM messages"
},
{
"key":"fetchTime",
"default":"15",
Expand Down Expand Up @@ -63,11 +78,6 @@
"default": "No response received from CMV after repeatedly broadcast TCMs.",
"description": "If the plugin does not receives any aknowledgement from CMV within the configured seconds that match the original TCM, the plugin will create an NO ACK message and display it on UI."
},
{
"key":"WebServicePort",
"default":"22222",
"description":"Server Port for V2X hub to receive TCM messages"
},
{
"key":"listTCM",
"default":"true",
Expand Down
Loading

0 comments on commit 9ac6eda

Please sign in to comment.