Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified: initialization.sh #548

Merged
merged 2 commits into from
Jul 10, 2023
Merged

modified: initialization.sh #548

merged 2 commits into from
Jul 10, 2023

Conversation

jwillmartin
Copy link
Contributor

@jwillmartin jwillmartin commented Jul 10, 2023 •
edited by paulbourelly999
Loading

PR Details

Description

Changes made to fix localhost address to reach V2X Hub Web UI and allow for script to be run multiple times without changing mysql password files.

Related Issue

https://usdot-carma.atlassian.net/browse/VH-1227
#592

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

gainesaw
gainesaw approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@gainesaw gainesaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made script more robust/error checking, looks good to me

@gainesaw gainesaw merged commit 639ad08 into develop Jul 10, 2023
8 checks passed
@paulbourelly999 paulbourelly999 deleted the initialization-fix branch July 10, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbourelly999 paulbourelly999 paulbourelly999 approved these changes

@gainesaw gainesaw gainesaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwillmartin @paulbourelly999 @gainesaw