Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2xHub: Update the code for ASN1.c parser to recognize SDSM message type + unit test #555

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

dan-du-car
Copy link
Contributor

@dan-du-car dan-du-car commented Aug 4, 2023

PR Details

Description

As an V2XHub developer, I want to update the code for ASN.1 parser to recognize these SDSM message type.

https://github.com/usdot-fhwa-stol/CARMASensitive/commit/a11650b48e350f5c54a2dfc0eb0afe14125c4080

Related Issue

CDAR-154
#589

Motivation and Context

CDA research

How Has This Been Tested?

Unit test

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

},
{ ATF_NOFLAGS, 0, offsetof(struct Attitude, roll),
(ASN_TAG_CLASS_CONTEXT | (1 << 2)),
-1, /* IMPLICIT tag at current level */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments added by code generation or did you add them?

Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@paulbourelly999 paulbourelly999 merged commit f4a2e61 into develop Aug 10, 2023
8 checks passed
@paulbourelly999 paulbourelly999 deleted the add_sdsm_asn_definition branch August 10, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants