Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CARMAStreets Plugin undefined behavior for Kafka Producer #559

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix CARMAStreets Plugin undefined behavior for Kafka Producer #559

merged 1 commit into from
Aug 24, 2023

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Aug 23, 2023 •
edited
Loading

PR Details

Description

Changes :

  • Added return statement for init method of kafka producer to avoid undefine behavior
  • Replaced error logs and null returns with throwing exceptions in Kafka consumer producer initialization in carma-streets plugin
  • Added stop command for devcontainer setup
  • Removed consumer group ID configuration, using plugin name instead

Related Issue

#558

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999
Added return statement for init method of kafka producer
a1c9c92 
to avoid undefine behavior

Replaced error logs and null returns with throwing exceptions
in Kafka consumer producer initialization in carma-streets plugin

Added stop command for devcontainer setup

Removed consumer group ID configuration, using plugin name instead
@paulbourelly999 paulbourelly999 changed the title Added return statement for init method of kafka producer Fix CARMAStreets Plugin undefined behavior for Kafka Producer Aug 23, 2023
willjohnsonk
willjohnsonk approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@willjohnsonk willjohnsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulbourelly999 paulbourelly999 marked this pull request as ready for review August 24, 2023 14:57
@paulbourelly999 paulbourelly999 merged commit aae33e6 into develop Aug 24, 2023
8 checks passed
@paulbourelly999 paulbourelly999 deleted the 558-carma-streets-plugin-fix branch August 24, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willjohnsonk willjohnsonk willjohnsonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbourelly999 @willjohnsonk