Temporary fix for TimeSyncMessage invalid json serialization #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willjohnsonk
reviewed
Sep 8, 2023
| // is currently out of scope. TMX Messages should be correctly serialize to | ||
| // and from json. This temporary fix simply using regex to look for numeric, | ||
| // null, and bool values and removes the quotations around them. | ||
| boost::regex exp("\"(null|true|false|[0-9]+(\\.[0-9]+)?)\""); |
There was a problem hiding this comment.
I know this is just a quick fix, but could this potentially cast numeric-only hex values differently than those with letters? If that is how they're passed via json in the existing code at least. Not sure if many, if any, fields will be affected either.
There was a problem hiding this comment.
Currently this is only being called on a single message, the TimeSyncMessage with two attributes seq and timestep, both are numeric. I do not think we need any protection against hex strings represented in json here.
willjohnsonk
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Temporary fix for TMX Message invalid JSON serialization (See Issue #561). Fix uses regex to filter out quotations from json string for attributes that are bool, numeric or null.
Related Issue
Motivation and Context
Maintain simulation time synchronization functionality of V2X-Hub/CARMA-Streets
How Has This Been Tested?
Tested in local dev container environment.
Types of changes
Checklist:
V2XHUB Contributing Guide