Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SDSM to immediate forward plugin configuration #574

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Added SDSM to immediate forward plugin configuration #574

merged 3 commits into from
Jan 11, 2024

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Dec 29, 2023 •
edited
Loading

PR Details

Description

Added SDSM to Immediate Forward Plugin Messages to forward and fixed PSID to match j3224 documentation

The system shall set the PSID value to the value assigned to “Sensor Sharing Service” (0x90), as listed by IEEE-RA website

Related Issue

CDAR-300

Motivation and Context

VRU UC1

How Has This Been Tested?

Types of changes

CDA Sim deployment tested

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review December 29, 2023 15:04
@paulbourelly999 paulbourelly999 marked this pull request as draft December 29, 2023 15:06
@paulbourelly999 paulbourelly999 marked this pull request as ready for review December 29, 2023 20:15
@paulbourelly999 paulbourelly999 self-assigned this Jan 11, 2024
dan-du-car
dan-du-car reviewed Jan 11, 2024
View reviewed changes
src/tmx/TmxApi/tmx/TmxApiMessages.h
@@ -196,7 +196,7 @@ enum msgPSID
rtcmCorrections_PSID = 0x8000,
signalRequestMessage_PSID = 0xE0000016,
signalStatusMessage_PSID = 0x8002,
sensorDataSharingMessage_PSID = 0x8002,
sensorDataSharingMessage_PSID = 0x90,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://standards.ieee.org/products-programs/regauth/psid/public/

@dan-du-car dan-du-car merged commit 136439a into develop Jan 11, 2024
9 checks passed
@dan-du-car dan-du-car deleted the fix/add_sdsm_to_immediate_forward branch January 11, 2024 21:43
@paulbourelly999 paulbourelly999 mentioned this pull request Jan 16, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-du-car dan-du-car dan-du-car approved these changes

Assignees

@paulbourelly999 paulbourelly999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbourelly999 @dan-du-car