add time sync logs #583
add time sync logs #583
Conversation
| @@ -18,12 +18,12 @@ namespace CDASimAdapter{ | |||
| success = GetConfigValue<double>("X", location.X); | |||
| success = success && GetConfigValue<double>("Y", location.Y); | |||
| success = success && GetConfigValue<double>("Z", location.Z); | |||
| PLOG(logINFO) << "Location of Simulated V2X-Hub updated to : {" << location.X << ", " | |||
| PLOG(logINFO) << "Location of Simulated V2X-Hub updated to : {" << location.X << ", " | |||
There was a problem hiding this comment.
Why do all you PRs have changes in random lines of code. There is no change here right?
There was a problem hiding this comment.
Do you have some kind of formatting running
There was a problem hiding this comment.
Yeah it is the vscode whitespace formatter. if you turn it off in the github to see then it moves it away
| std::string payload =msg.to_string(); | ||
| PLOG(logDEBUG1) << "Sending Time Sync Message " << msg << std::endl; | ||
| auto time_now = std::chrono::system_clock::now(); |
There was a problem hiding this comment.
Can we put this entire logic inside a block that is skipped if not in debug mode and add a comment here indicating what this is for and maybe that it will eventually be removed.
|
Also I just merged a PR that fixes some all of the CI stuff into the release candidate. I had previously already fixed it in develop. You may want to rebase you PR on that to make sure the failures here are not independent and to get sonar reports. |
PR Details
Description
Adds logs to support usdot-fhwa-stol/carma-analytics-fotda#43
Related Issue
CDAR-774
Motivation and Context
Data Analysis
How Has This Been Tested?
Types of changes
Checklist:
V2XHUB Contributing Guide