-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified: configuration/arm64/docker-compose.yml #585
Conversation
modified: configuration/arm64/initialization.sh modified: configuration/arm64/mysql/add_v2xhub_user.bash
@@ -1,5 +1,3 @@ | |||
version: '3.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwillmartin Why are we removing this version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulbourelly999 It was throwing a compatibility warning when running docker compose. I read through their documentation and the versioning is optional/doesn't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this back
@@ -16,14 +14,15 @@ services: | |||
- mysql_root_password | |||
volumes: | |||
- ./mysql/localhost.sql:/docker-entrypoint-initdb.d/localhost.sql | |||
- ./mysql/port_drayage.sql:/docker-entrypoint-initdb.d/port_drayage.sql | |||
# - ./mysql/port_drayage.sql:/docker-entrypoint-initdb.d/port_drayage.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea here that we do not want to default to having port drayage functionality on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulbourelly999 Yeah. It's not used by anybody at the moment. It'll be better to have it commented out unless somebody will use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment indicating how to get port drayage functionality back and/or to come up with a more elegant solution to not including port drayage by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments with instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All, I think we need to leave the port_drayage as is. The expectation is that whatever was deployed in the past should be backwards compatible or scenarios would continue to work as is, unless we notify the client we're removing this feature or retiring it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jwillmartin Make the changes we talked about and then I am good to merge.
@jwillmartin Also may want to create a github issue for documentation of what errors were encountered and triggered this change. |
modified: configuration/arm64/initialization.sh
sudo pip3 install docker-compose | ||
sudo apt update -y && sudo apt upgrade -y | ||
sudo docker-compose up -d | ||
for pkg in docker.io docker-doc docker-compose podman-docker containerd runc; do sudo apt-get remove $pkg; done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was getting warnings about gpg key deprecation. Updated and tested using Docker's official Debian installation steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All, any changes that are done in arm64 that applies to amd64 should be done together and changes should be integration tested to make sure it works as expected without introducing any new issues.
@@ -16,14 +14,15 @@ services: | |||
- mysql_root_password | |||
volumes: | |||
- ./mysql/localhost.sql:/docker-entrypoint-initdb.d/localhost.sql | |||
- ./mysql/port_drayage.sql:/docker-entrypoint-initdb.d/port_drayage.sql | |||
# - ./mysql/port_drayage.sql:/docker-entrypoint-initdb.d/port_drayage.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All, I think we need to leave the port_drayage as is. The expectation is that whatever was deployed in the past should be backwards compatible or scenarios would continue to work as is, unless we notify the client we're removing this feature or retiring it.
modified: configuration/amd64/initialization.sh modified: configuration/arm64/docker-compose.yml modified: configuration/arm64/initialization.sh
sudo apt update -y && sudo apt upgrade -y | ||
|
||
#installing necessary and useful apps | ||
sudo apt-get install chromium-browser -y #Chrome required for CARMA platform/V2X Hub UI(?) | ||
sudo apt install curl -y #Curl for downloading files over internet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why as curl removed. Is it not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be added back. It is still used
sudo apt-get update | ||
sudo apt-get install ca-certificates curl | ||
sudo install -m 0755 -d /etc/apt/keyrings | ||
sudo curl -fsSL https://download.docker.com/linux/$(. /etc/os-release && echo "$ID")/gpg -o /etc/apt/keyrings/docker.asc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add curl back so this script does not fail for people without curl installed.
sudo apt update -y && sudo apt upgrade -y | ||
|
||
#installing necessary and useful apps | ||
sudo apt-get install chromium-browser -y #Chrome required for CARMA platform/V2X Hub UI(?) | ||
sudo apt install curl -y #Curl for downloading files over internet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add curl back. See comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing left is to add curl back.
Quality Gate passedIssues Measures |
PR Details
Description
Updated arm64 configuration files to fix initial setup, which was no longer working.
Updated:
mariabd-client version
docker compose version
docker-compose.yml
Related Issue
#594
Motivation and Context
The initialization.sh and add_v2xhub_user.bash scripts were no longer working in arm64 configuration
How Has This Been Tested?
Tested on latest Raspberry Pi OS on a Pi 4. Initialization and user addition worked.
Types of changes
Checklist:
V2XHUB Contributing Guide