Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New workflow for PRs #587

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Mar 21, 2024

PR Details

Description

This PR removes CircleCI workflow configurations for automated release and arm image builds and replaces them with github actions. We now have 5 workflows:

  1. build_php_docker_image: Builds and pushes docker image for php in arm and amd architectures. Runs on develop, master,release candidates and on pushed tags
  2. build_port_drayage_docker_image: Builds and pushed docker image for port drayage webservice in arm and amd architectures .Runs on develop, master,release candidates and on pushed tags
  3. build_v2xhub_docker_image: Builds and pushed docker image for v2xhub in arm and amd architectures .Runs on develop, master,release candidates and on pushed tags
  4. pull_request: Builds all docker images in arm and amd (no push) architectures. Runs only on pull requests
  5. sonar_scanner: Builds source code, runs unit tests and runs static analysis (sonar scanner) and pushes results. Runs on develop, master and on all open PRs.

Related Issue

VH-1278

Motivation and Context

Remove CircleCI and use platform/architecture for docker images

How Has This Been Tested?

@jwilliammartin Could you test the following on ARM devices.
docker compose pull and run new images. Ensure no docker images crash on both V2X-Hub and Port Drayage web UI are accessible.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review March 25, 2024 17:22
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@paulbourelly999 paulbourelly999 merged commit 24d6989 into develop Mar 26, 2024
3 of 4 checks passed
@paulbourelly999 paulbourelly999 deleted the vh-1278-update-to-github-actions branch March 26, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants