Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXC-28: Update CARMA Cloud Plugin to have configurable IP/Port #593

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Apr 3, 2024

PR Details

Description

Update CARMA Cloud plugin to allow for configurable target IP/Port for sending CARMA Cloud REST Requests
image
image

NOTE: Large changeset is due to correcting line ending characters for file. Feel free to double check change set in text diff tool of your choice. Here is what I got
image
image
image
image
image

Related Issue

CXC-28

Motivation and Context

To support CARMA Cloud CDASim Integration testing

How Has This Been Tested?

Locally integration tested using devcontainer to ensure configurable parameters were available and modified URL correctly

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review April 3, 2024 20:11
Copy link

sonarcloud bot commented Apr 3, 2024

@paulbourelly999 paulbourelly999 merged commit 9ac6eda into develop Apr 4, 2024
3 of 4 checks passed
@paulbourelly999 paulbourelly999 deleted the cxc-28-configurable-carma-cloud-ip-port branch April 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants