TelematicPlugin: Memory leak #599
Conversation
dan-du-car
requested review from
paulbourelly999
and removed request for
paulbourelly999
dan-du-car
changed the title
| @@ -238,7 +240,10 @@ namespace TelematicBridge | |||
| } | |||
| else | |||
| { | |||
| json["payload"] = StringToJson(cJSON_Print(msg->payload)); | |||
| // Render a cJSON entity to text for transfer/storage. Free the char* when finished. | |||
| char * payloadPtr = cJSON_Print(msg->payload); | |||
There was a problem hiding this comment.
Can we replace this with a smart pointer to remove the need for free?
There was a problem hiding this comment.
It only returns a char* Type. How do we put this in smart pointer?
| @@ -238,7 +240,9 @@ namespace TelematicBridge | |||
| } | |||
| else | |||
| { | |||
| json["payload"] = StringToJson(cJSON_Print(msg->payload)); | |||
| // Render a cJSON entity to text for transfer/storage. Free the char* when finished. | |||
| auto payloadPtr = std::make_unique<char*>(cJSON_Print(msg->payload)); | |||
There was a problem hiding this comment.
Apparently std::make_unique is sort of a wrapper for new (https://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique) and actually creates a new object from the passed in parameter. This is likely why we still see the memory leak with this in. Apparently this is the more appropriate way to create a unique pointer from the returned char*
std::unique_ptr<char, decltype(std::free) *> payloadPtr{ cJSON_Print(msg->payload), std::free };Could you try this and see if it works?
|
PR Details
Description
Fix memory leaks issues with several variables created with malloc or new.
Related Issue
#575
Motivation and Context
How Has This Been Tested?
Local integration test
Types of changes
Checklist:
V2XHUB Contributing Guide