Fix tcm intermittent reception

[dan-du-car]

PR Details

Description

Fix the TCM intermittent reception issue where carma cloud sends TCMs in an http request and v2xhub CARMACloudPlugin sometimes does not receive the TCMs. Replace the OpenAI generated code with QhttpEngine recommended functional call, refer to: https://ci.quickmediasolutions.com/job/qhttpengine-documentation/doxygen/classQHttpEngine_1_1QObjectHandler.html.

Related Issue

#601
#603

Motivation and Context

CARMA cloud integration testing

How Has This Been Tested?

Local integration test

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• I have added any new packages to the sonar-scanner.properties file
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
  V2XHUB Contributing Guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[paulbourelly999]

Address code smells. It is also not great practice to manually edit generated code but if it is necessary I guess it is not the only place we do this. Lastly do we know at all why the previous implementation did not work? Without knowing that how have we confirmed that this implementation fixes the issue?

@paulbourelly999 Bryan and I both tested this change, and it worked. It is not an edit of the generated code, rather a complete replacement of it with the use the QhttpEngine implementation. I think the generated code did not work for some time now because I receive reports on the message loss from multiple plugins that use this generated code.

[jwillmartin]

Using official documentation/guidance is more appropriate than generated code. This looks good and I see your testing passed.

[jwillmartin]

My bad, I see there were some code smells when I opened the link to sonar cloud. I agree with Paul on addressing those.

[paulbourelly999]

@dan-du-car Wait so the edits are not on the generated code, That makes sense. You mentioned it is a replacement of generated code. Does that mean some of the generated code can be removed? You also mentioned that this is an issue with other OpenAPI generated REST clients/servers. If so we should create issues to remove the problematic code and include any evidence you have of these other services having similar issues.

@paulbourelly999 The generated code is in the server lib. I think some OpenAI related code in the CARMACloudPlugin is a copy with some modification from there: https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/develop/ext/server/src/main.cpp.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[paulbourelly999]

Looks good. If you believe other REST servers (ERV or TIM or Pedestrian ) will have a similar issue please create a GitHub issue to track this.