Add configuration parameters for RSUHealthMonitorPlugin #613
Conversation
| @@ -19,7 +19,7 @@ | |||
| }, | |||
| { | |||
| "key":"RSUConfigurationList", | |||
| "default":"{ \"RSUS\": [ { \"RSUIp\": \"192.168.XX.XX\", \"SNMPPort\": \"161\", \"AuthPassPhrase\": \"dummy\", \"User\": \"authOnlyUser\", \"RSUMIBVersion\": \"RSU4.1\" },{ \"RSUIp\": \"192.168.00.XX\", \"SNMPPort\": \"162\", \"AuthPassPhrase\": \"tester\", \"User\": \"authPrivUser\", \"RSUMIBVersion\": \"RSU4.1\" }] }", | |||
| "default":"{ \"RSUS\": [ { \"RSUIp\": \"192.168.XX.XX\", \"SecurityLevel\":\"authPriv\", \"SNMPPort\": \"161\", \"AuthPassPhrase\": \"dummy\", \"User\": \"authOnlyUser\", \"RSUMIBVersion\": \"RSU4.1\" ,\"RSUIdentifier\":\"NA\"},{ \"RSUIp\": \"192.168.00.XX\", \"SecurityLevel\":\"authPriv\", \"SNMPPort\": \"162\", \"AuthPassPhrase\": \"tester\", \"User\": \"authPrivUser\", \"RSUMIBVersion\": \"RSU4.1\" ,\"RSUIdentifier\":\"NA\"}] }", | |||
There was a problem hiding this comment.
Is RSU Name or ID not the identifier? I think the RSU spec has snmp endpoints for both.
There was a problem hiding this comment.
RSUs specs does have RSU Name and ID. However, they usually have the same values across RSUs. We could use the RSUs specs, and that requires to update each individual RSUs setup either via SNMP request or some other ways. For the telematic tool purpose, I assume this is the least effort to meet the telematic requirement.
| @@ -27,6 +27,7 @@ namespace RSUHealthMonitor | |||
| for (auto rsuConfig : _rsuConfigListPtr->getConfigs()) | |||
| { | |||
| auto rsuStatusJson = _rsuWorker->getRSUStatus(rsuConfig.mibVersion, rsuConfig.rsuIp, rsuConfig.snmpPort, rsuConfig.user, rsuConfig.authPassPhrase, rsuConfig.securityLevel, SEC_TO_MICRO); | |||
| rsuStatusJson[RSUIdentifierKey] = rsuConfig.RSUIdentifier; | |||
There was a problem hiding this comment.
Why are we pulling this from the configuration, are we not setting this on the RSU?
There was a problem hiding this comment.
This is to directly sent as part of the RSU status payload.
There was a problem hiding this comment.
One issue I have with the current setup is that is seems we are creating our own RSU Identifier instead of using the existing RSU name and/or ID fields both of which can be set and retrieved from the RSU via SNMP.
@paulbourelly999 Removed
|
There was a problem hiding this comment.
Every thing looks good to me know. Could you just link the Jira Issue https://usdot-carma.atlassian.net/browse/VH-1316 and also update the PR description to no longer include anything about an identifier
PR Details
Description
Add configuration parameter to set SNMP security level.
Related Issue
usdot-fhwa-stol/cda-telematics#213
JIRA
https://usdot-carma.atlassian.net/browse/VH-1316
Motivation and Context
Telematic tool integration test
How Has This Been Tested?
Unit test
Types of changes
Checklist:
V2XHUB Contributing Guide