Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Obsolete docker compose file version #614

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

jwillmartin
Copy link
Contributor

@jwillmartin jwillmartin commented Jun 4, 2024

modified:   configuration/docker-compose.yml

PR Details

Description

Removed the "version:" tag a the top of the docker-compose files. These are no longer needed and are obsolete in current and future versions of Docker.

Related Issue

VH-1312

Motivation and Context

Because the version tag is obsolete, a warning note is published every time a user uses the docker-compose files to start the V2X Hub containers. Removing this tag will cause no changes in functionality and will remove the warning.

How Has This Been Tested?

Tags removed and tested locally. Everything worked as intended and warning message was no longer shown.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

	modified:   configuration/docker-compose.yml
@paulbourelly999 paulbourelly999 changed the title modified: .devcontainer/docker-compose-vscode.yml Remove Obsolete docker compose file version Jun 5, 2024
	modified:   .devcontainer/docker-compose-vscode.yml
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@paulbourelly999
Copy link
Contributor

Waiting to merge until docker build is complete.

@paulbourelly999 paulbourelly999 merged commit ab664ac into develop Jun 6, 2024
3 checks passed
@paulbourelly999 paulbourelly999 deleted the vh-1312_remove_compose_version branch June 6, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants