Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUST Sensor Driver #618

Merged
merged 19 commits into from
Jun 28, 2024
Merged

MUST Sensor Driver #618

merged 19 commits into from
Jun 28, 2024

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Jun 18, 2024

PR Details

Description

MUST Sensor Driver Plugin

Adding MUST Sensor Driver to V2X-Hub. Documentation on MUST Sensor Driver will be included in README. This new plugin is responsible for consuming UDP CSV (Comma Separated Values) string packets that represent detections from the MUST Sensor. These will be converted into SensorDetectedObject which can be forwarded to the CARMA Streets Sensor Data Sharing Service to create SDSMs (Sensor Data Sharing Messages).

Sensor Detected Object

This PR includes updates to the SensorDetectedObject TMX message including removing references to simulation since this message will no longer be exclusively used in simulation. This PR also includes adding fields and JSON serialization methods to the SensorDetectedObject. This was previously unnecessary since incoming messages from CDASim (our simulation environment) were already JSON strings and were just passed via payload.

UDP Server

This PR also includes updates to the UDPServer class in TMX Utils. It provides a method to directly consume string payloads from the UDPServer. Many users of the UDP Server have to write this logic when they use the UDP Server. Adding it to the class is in an effort to reduce duplication of this logic across V2X-Hub.

Future Improvements

This PR further highlights the needs to address/fix #561 which currently prevents from correct JSON serialization and deserialization of TMX messages and prevents defining messages with nested objects.

Related Issue

FCP-3 (Design)
FCP-4 (Implementation)

Motivation and Context

Freight Cooperative Perception

How Has This Been Tested?

Unit testing and script based integration testing. For instructions for script based integration testing refer to Functionality Testing section of the README document.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sensorId and projString from configuration
@paulbourelly999 paulbourelly999 marked this pull request as ready for review June 24, 2024 18:22
public:
/**
* @brief Constructor
* @param name Plugin Name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this comment add any value.

Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
45.65% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@paulbourelly999 paulbourelly999 self-assigned this Jun 27, 2024
@paulbourelly999 paulbourelly999 merged commit adfb5a8 into develop Jun 28, 2024
2 of 3 checks passed
@paulbourelly999 paulbourelly999 deleted the fcp-3-must-sensor-driver branch June 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TMX Messages currently serialize all attributes as strings
2 participants