Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions with start and stop locations at PVL lab #619

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

dan-du-car
Copy link
Collaborator

@dan-du-car dan-du-car commented Jun 27, 2024

PR Details

Description

Update V2X Hub Port Drayage Plugin actions with new start/stop locations for testing in PVL Lab:

  • PICKUP location: [3.7, -5.8]
  • EXIT_STAGING_AREA location: [0.0, 0.2]

Latitude is mapped to Y axis, and longitude is mapped to X axis.
The locations are picked from the pvl graph: https://github.com/usdot-fhwa-stol/c1t_bringup/blob/develop/graphs/pvl_graph.geojson?short_path=4609dc2

Related Issue

https://usdot-carma.atlassian.net/browse/CF-495

Motivation and Context

NA

How Has This Been Tested?

NA

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a related JIRA Ticket. Also It may be worth while creating a separate SQL file for the C1T testing. This file is currently used for our functionality testing. If we change things here that impact that we need to update that documentation

@dan-du-car dan-du-car marked this pull request as draft July 1, 2024 00:12
@dan-du-car dan-du-car marked this pull request as ready for review July 1, 2024 13:25
Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I was initially on the fence about this but could we add a README here outlining what this sql file is for and how to use it.
Example

PVL Actions

These are Port Drayage actions created for the PVL Lab for testing of C1T functionality.
Optional: Included some screen shot of the actions on a map

Instructions

db:
   image: mysql:8.0
   volumes:
       ./mysql/pvl_lab/port_drayage.sql


@dan-du-car
Copy link
Collaborator Author

Please add a related JIRA Ticket. Also It may be worth while creating a separate SQL file for the C1T testing. This file is currently used for our functionality testing. If we change things here that impact that we need to update that documentation

@paulbourelly999 Addressed

# PVL Actions
These are Port Drayage actions created for the PVL Lab for testing of C1T functionality.

## Instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-du-car lol these were place holder instructions. I think as the are currently written they do not work. You have to update the volume here and maybe add a sentence about replacing the old actions with the ones configured for PVL

Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My instructions were just place holders. They need a little editing to make them actually work.

Copy link

sonarcloud bot commented Jul 1, 2024

@dan-du-car dan-du-car merged commit 8cb2838 into develop Jul 1, 2024
2 of 3 checks passed
@dan-du-car dan-du-car deleted the add_start_stop_locations branch July 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants