Fix ped plugin #620
Merged
Fix ped plugin #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/v2i-hub/PedestrianPlugin/src/PedestrianPlugin.cpp modified: src/v2i-hub/PedestrianPlugin/src/include/PedestrianPlugin.hpp
modified: src/v2i-hub/PedestrianPlugin/src/include/PedestrianPlugin.hpp
| @@ -633,7 +633,7 @@ int CommandPlugin::WSCallbackBASE64( | |||
| argsList[arg.first] = arg.second.data(); | |||
| } | |||
| } | |||
| catch (exception argsEx) | |||
| catch (exception &argsEx) | |||
There was a problem hiding this comment.
catch(const std::exception &argEx)Also where you just address a code smell or why are there changes to this file at all.
There was a problem hiding this comment.
This was just to address a code smell
modified: src/v2i-hub/PedestrianPlugin/src/PedestrianPlugin.cpp modified: src/v2i-hub/PedestrianPlugin/src/include/PedestrianPlugin.hpp
|
modified: examples/tmx-exampleapps/EmptyPlugin/src/EmptyPlugin.cpp modified: ext/build.sh modified: src/tmx/TmxApi/CMakeLists.txt modified: src/tmx/TmxApi/tmx/messages/message_document.hpp deleted: src/tmx/TmxApi/tmx/pugixml/pugiconfig.hpp deleted: src/tmx/TmxApi/tmx/pugixml/pugixml.cpp deleted: src/tmx/TmxApi/tmx/pugixml/pugixml.hpp deleted: src/tmx/TmxApi/tmx/pugixml/readme.txt
modified: src/v2i-hub/PedestrianPlugin/src/PedestrianPlugin.cpp modified: src/v2i-hub/PedestrianPlugin/src/include/PedestrianPlugin.hpp
ext/build.sh
Outdated
| @@ -72,3 +72,11 @@ make -j${numCPU} | |||
| make install | |||
| popd | |||
|
|
|||
| # pugixml | |||
| pushd /tmp | |||
| git clone https://github.com/zeux/pugixml.git | |||
There was a problem hiding this comment.
We may want to target a specific release to avoid new releases breaking our build
There was a problem hiding this comment.
Good call, changed to v1.14
paulbourelly999
requested changes
Aug 13, 2024
modified: src/v2i-hub/PedestrianPlugin/manifest.json modified: src/v2i-hub/PedestrianPlugin/scripts/sendPSM.py modified: src/v2i-hub/PedestrianPlugin/src/PedestrianPlugin.cpp modified: src/v2i-hub/PedestrianPlugin/src/include/PedestrianPlugin.hpp
jwillmartin
requested review from
paulbourelly999
and removed request for
abey-yoseph
paulbourelly999
approved these changes
Aug 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
These changes address a memory leak in the WebService/PSM functionality of the plugin. It also allows a user to switch between using FLIR(WebSocket) and PSM(WebService) without crashing or generating segmentation faults.
Related Issue
#497
Motivation and Context
Users of this plugin have noticed memory loss and error code generation while using this plugin. Users have also requested a fix for the #497 issue.
How Has This Been Tested?
Tested using a script to send 1000 PSM XMLs to the plugin. No messages were lost.
Tested using local FLIR camera to ensure functionality was maintained.
Switched between DataProviders (PSM/FLIR) in various combinations to ensure threads were closed or joined properly.
Types of changes
Checklist:
V2XHUB Contributing Guide