Vh 1216 fix spat plugin segfault simulation #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbourelly999
commented
Jul 22, 2024
paulbourelly999
commented
Jul 22, 2024
paulbourelly999
requested review from
DokurOmkar
and removed request for
jwillmartin
DokurOmkar
requested changes
Jul 24, 2024
DokurOmkar
reviewed
Jul 25, 2024
DokurOmkar
approved these changes
Jul 26, 2024
dan-du-car
reviewed
Jul 29, 2024
dan-du-car
reviewed
Jul 29, 2024
|
|
||
| ## Introduction | ||
|
|
||
| The SPaT Plugin is responsible for receiving information from the Traffic Signal Controller (TSC or SC) necessary for broadcasting Signal Phase and Timing (SPaT) messages. This includes querying any SNMP objects to determine TSC state and listen for any broadcast SPaT information from the TSC. |
There was a problem hiding this comment.
Is this received information used to populate self-defined Ntcip1202 https://github.com/usdot-fhwa-OPS/V2X-Hub/blob/develop/src/v2i-hub/SpatPlugin/src/NTCIP1202.h? Can we add additional details about the received information
| if (state == IvpPluginState_registered) { | ||
| UpdateConfigSettings(); | ||
| SpatPlugin::SpatPlugin(const std::string &name) :PluginClientClockAware(name) { | ||
| spatReceiverThread = std::make_unique<tmx::utils::ThreadTimer>(std::chrono::milliseconds(5)); |
There was a problem hiding this comment.
Is there a reason we choose 5 milliseconds?
dan-du-car
approved these changes
Jul 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This pull request updates the SPAT plugin to fix a number of issues with the legacy implementation.
Additionally to help provide these improvements in the SPaT plugin, several improvements were made in the TMX Utils functionality.
Related Issue
VH-1216
Motivation and Context
Fix SPaT plugin for simulation and improve overall usability and maintainability.
How Has This Been Tested?
Tested using virtual signal controller for both binary and hex spat payloads.
Also tested in sim mode using the following steps
src/v2i-hub/CDASimAdapter/scripts/send_timestep_udp.pyscript to send periodic time sync messages.Types of changes
Checklist:
V2XHUB Contributing Guide