-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VH 1314 - Allow V2X-Hub Web UI browser access without self signed certificate warning acceptance #622
VH 1314 - Allow V2X-Hub Web UI browser access without self signed certificate warning acceptance #622
Conversation
Please make sure the PR describes the manual step we are removing in the description. "updated to ignore the certificates for localhost on google chrome and chromium browsers to remove the manual step" (navigating to websocket URL and accepting self signed certificate. |
configuration/initialization.sh
Outdated
@@ -150,3 +150,5 @@ cd "$mysqlDir" || return # return in case cd fails | |||
|
|||
chromium-browser "http://127.0.0.1" > /dev/null 2>&1 & | |||
chromium-browser "https://127.0.0.1:19760" > /dev/null 2>&1 & | |||
google-chrome --ignore-certificate-errors localhost | |||
chromium-browser --ignore-certificate-errors localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need one browser and we also no longer need the "https://127.0.0.1:19760" tab right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. I have removed these lines from the script now:
chromium-browser "http://127.0.0.1" > /dev/null 2>&1 &
chromium-browser "https://127.0.0.1:19760" > /dev/null 2>&1 &
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Addressed all the comments |
configuration/README.md
Outdated
@@ -59,3 +59,9 @@ To support execution in a simulated environment, V2X-Hub is in the process of in | |||
* **V2XHUB_IP** – Environment variable for storing IP address of V2X Hub. | |||
* **INFRASTRUCTURE_ID** – Environment variable for storing infrastructure id of V2X Hub. | |||
* **SENSOR_JSON_FILE_PATH** – Environment variable for storing path to sensor configuration file. This is an optional simulation environment variable that allows for setting up simulated sensor for a V2X-Hub instance. Example file can be found in the **CDASimAdapterPlugin** tests [here](../src/v2i-hub/CDASimAdapter/test/sensors.json). | |||
|
|||
### Open V2X-Hub in Google Chrome | |||
To open V2X-Hub in Google Chrome, run this command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong command since we use chromium below. We can offer this as an option of the user has google chrome instead of chromium. A note explaining why we do this may be useful. Something link
Note
V2X-Hub Server uses a secure WebSocket connection to communicate with the browser. V2X-Hub Server uses a self-signed certificate instead of one signed by a trust certificate authority (CA) for this secure connection, which most browsers will not trust until explicitly told to do so by navigating the the WebSocket URL (https://<v2xhub_ip>:19760) and accepting the risk . The --ignore-certificate-errors
option instructs the browser to ignore certificate errors and warnings which removes manually effort of accepting this risk on V2X-Hub deployments. Using the browser with this option enabled to access the internet or any other application is not advised as it is a security risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested more changes
Addressed all the comments. |
configuration/README.md
Outdated
@@ -59,3 +59,12 @@ To support execution in a simulated environment, V2X-Hub is in the process of in | |||
* **V2XHUB_IP** – Environment variable for storing IP address of V2X Hub. | |||
* **INFRASTRUCTURE_ID** – Environment variable for storing infrastructure id of V2X Hub. | |||
* **SENSOR_JSON_FILE_PATH** – Environment variable for storing path to sensor configuration file. This is an optional simulation environment variable that allows for setting up simulated sensor for a V2X-Hub instance. Example file can be found in the **CDASimAdapterPlugin** tests [here](../src/v2i-hub/CDASimAdapter/test/sensors.json). | |||
|
|||
### Open V2X-Hub in Google Chrome | |||
If the chromium browser is not available, run this command to open V2X-Hub in google chrome: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To access V2X-Hub Admin Web UI from a different machine on the same network please use either chromium or google-chrome browser and run the following command
chromium --ignore-certificate-errors <v2xhub_ip>
or
google-chrome --ignore-certificate-errors <v2xhub_ip>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the README file.
Quality Gate passedIssues Measures |
PR Details
Description
In this PR, initialization script is updated to ignore the certificates for localhost on google chrome and chromium browsers to remove the manual step of navigating to websocket URL and accepting self signed certificate. This will allow to access V2X-Hub Web UI without accepting the risk in an other tab.
Related Issue
VH-1314
Motivation and Context
How Has This Been Tested?
This has been tested locally by running the initialization script and making sure that the web page opens with the login screen.
Types of changes
Checklist:
V2XHUB Contributing Guide