VH 1324 - Filter the versions returned from the initialization script #623
Conversation
|
| @@ -23,9 +23,12 @@ latest_version=$(echo "$release_info" | grep -o '"tag_name": *"[^"]*"' | cut -d | |||
| # Fetching all tags from Git repository | |||
| tags=$(git ls-remote --tags https://github.com/usdot-fhwa-OPS/V2X-Hub.git | awk -F/ '{print $3}' | sort -V) | |||
There was a problem hiding this comment.
On issue I am realizing right now is that getting tags may return tags that are not associated with any release. Maybe we should considered install gh' as part of this script and using the output of gh release list` which looks like this
This ensures all provided options are actual releases, does not included any duplicates and includes information about release date and most recent release. What do you think. Only additional edit that may be necessary is to make sure the prompt for selecting a release indicates that you use the tag name.
There was a problem hiding this comment.
As using "gh" would require an additional step of installing it. As part of this bug, we can work on removing the unwanted characters and add a follow up story to make an enhancement.
In the follow up story, we can add a logic to check if gh installed or not and add installation commands within this script.
paulbourelly999
deleted the
vh-1324_clean_up_versions_from_the_initialization_script
branch
PR Details
Description
In this PR, updated the docker compose file to change the "LOCAL_IP" variable to "V2XHUB_IP" and updated the initialization script to remove the following from the returned versions:
Related Issue
Motivation and Context
How Has This Been Tested?
This has been tested by running the script locally. A screenshot is attached below after testing.
Types of changes
Checklist:
V2XHUB Contributing Guide