Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VH 1319 - Make V2X-Hub previous releases to support multi architecture docker images #625

Conversation

DokurOmkar
Copy link
Contributor

PR Details

Description

In this PR,

  • Updated the initialization script to print only versions 7.0 and above that support multi architecture deployment.
  • Updated the add user script to create V2X-Hub username and password based on the deployment version.

Related Issue

Motivation and Context

This work is to improve the V2X-Hub deployment process

How Has This Been Tested?

After creating the multi architecture docker images, they have been tested by deploying them on both AMD and ARM devices.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

V2XHUB_VERSION="$1"
else
# Prompt user for V2XHUB_VERSION
read -p "Enter the deployed V2X-Hub version number: " V2XHUB_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Updated the code now.

Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested. Was able to catch this by running your script through shell check. You are only required to fix the portions of the script you modified.

Copy link

sonarcloud bot commented Jul 26, 2024

@DokurOmkar DokurOmkar merged commit 2b9f38f into develop Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants