-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install carma-clock-1 from ubuntu distribution (correct version) #627
Conversation
# add the STOL APT repository | ||
echo "deb [trusted=yes] http://s3.amazonaws.com/stol-apt-repository develop main" > /etc/apt/sources.list.d/stol-apt-repository.list | ||
echo "deb [trusted=yes] http://s3.amazonaws.com/stol-apt-repository ${DISTRIB_CODENAME} main" > /etc/apt/sources.list.d/stol-apt-repository.list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I am curious how to check the list of available ubuntu distributions support of this carma-clock-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would that be necessary. It is not necessary for any other package you install via apt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is limited and supported for ubuntu OS only? Also if the ubuntu is version 16.06 or 24.04, does this carma-clock-1 still exist? If not, do we have a visible document that tells users that this package is only compatible with certain ubuntu version? If someone use Raspberry Pi OS, can they install this with APT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is excessive. When we release CARMA Platform or any other library we can document which ubuntu distributions we have built it on (https://github.com/usdot-fhwa-stol/carma-time-lib/pulls?tab=readme-ov-file#install-library) by listing prerequisites for using the application or library but this does not need to be available from the package manager. Additionally it is definitely not in the scope for this fix. When you install other applications via apt they do not list ubuntu compatibility. We have documented on carma-time-lib how to install this package via apt and provide an ubuntu distribution. Anything beyond that, I do not think is our responsibility.
Quality Gate passedIssues Measures |
PR Details
Description
This PR is to correct the version of
carma-clock-1
V2X-Hub pulls from our Debian repository. Previously it pulled from develop bucket which is no longer used and therefore contains versions of the library from 2023. Currently we push a debian package for each ubuntu distribution.Related Issue
Motivation and Context
Pull correct version of
carma-clock-1
package created from https://github.com/usdot-fhwa-stol/carma-time-libHow Has This Been Tested?
CI Process
Types of changes
Checklist:
V2XHUB Contributing Guide