Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install carma-clock-1 from ubuntu distribution (correct version) #627

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Install carma-clock-1 from ubuntu distribution (correct version) #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/install_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
# exit on errors
set -e

# Get ubuntu distribution code name. All STOL APT debian packages are pushed to S3 bucket based on distribution codename.
. /etc/lsb-release

# add the STOL APT repository
echo "deb [trusted=yes] http://s3.amazonaws.com/stol-apt-repository develop main" > /etc/apt/sources.list.d/stol-apt-repository.list
echo "deb [trusted=yes] http://s3.amazonaws.com/stol-apt-repository ${DISTRIB_CODENAME} main" > /etc/apt/sources.list.d/stol-apt-repository.list
Copy link
Contributor

@dan-du-car dan-du-car Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am curious how to check the list of available ubuntu distributions support of this carma-clock-1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would that be necessary. It is not necessary for any other package you install via apt?

Copy link
Contributor

@dan-du-car dan-du-car Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is limited and supported for ubuntu OS only? Also if the ubuntu is version 16.06 or 24.04, does this carma-clock-1 still exist? If not, do we have a visible document that tells users that this package is only compatible with certain ubuntu version? If someone use Raspberry Pi OS, can they install this with APT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is excessive. When we release CARMA Platform or any other library we can document which ubuntu distributions we have built it on (https://github.com/usdot-fhwa-stol/carma-time-lib/pulls?tab=readme-ov-file#install-library) by listing prerequisites for using the application or library but this does not need to be available from the package manager. Additionally it is definitely not in the scope for this fix. When you install other applications via apt they do not list ubuntu compatibility. We have documented on carma-time-lib how to install this package via apt and provide an ubuntu distribution. Anything beyond that, I do not think is our responsibility.


apt-get update

Expand Down
Loading