Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port ekf_localizer #253

Merged
merged 5 commits into from
Jul 14, 2023
Merged

port ekf_localizer #253

merged 5 commits into from
Jul 14, 2023

Conversation

adev4a
Copy link

@adev4a adev4a commented Jul 10, 2023

PR Details

This PR ports the ekf localizer package to ros2.

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Unit Tested and locally integration tested

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

JonSmet
JonSmet requested changes Jul 11, 2023
View reviewed changes
Copy link

@JonSmet JonSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a partial review for now (through ekf_localizer.hpp), and will plan to complete the rest of the review later today.

core_perception/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp Outdated Show resolved Hide resolved
core_perception/ekf_localizer/include/ekf_localizer/ekf_localizer.hpp Show resolved Hide resolved
@JonSmet JonSmet merged commit d217ee2 into carma-develop Jul 14, 2023
@JonSmet JonSmet deleted the feature/port_ekf_localizer_ros2 branch July 14, 2023 16:12
@adev4a adev4a changed the title port ekf_filter port ekf_localizer Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonSmet JonSmet JonSmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adev4a @JonSmet