fix invalid condition

[MishkaMN]

PR Details

Description

Supports usdot-fhwa-stol/carma-platform#2179
The assumption being used here is wrong where if there is only 1 signal_state in SPAT, that signal continues in perpetuity. The signal in fact changes after this single state. If the requested time is further in time than the states available, the function should return RED.

Related GitHub Issue

usdot-fhwa-stol/carma-platform#2180

Related Jira Key

CDAR-125

Motivation and Context

See above

How Has This Been Tested?

Tested in cdasim

Types of changes

• Defect fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that cause existing functionality to change)

Checklist:

• I have added any new packages to the sonar-scanner.properties file
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.