-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub actions workflows for Docker builds #257
Conversation
.github/workflows/dockerhub.yml
Outdated
- "develop" | ||
- "master" | ||
- "release/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what these lines do? Is it saying to build these branches, or ignore them? carma-develop, master, release branches we do want to build right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I got my answer in private chat from Sai:
ci.yml: it will build and run units for sonar scanner analysis but does not push any images to docker hub dockerhub.yml: it will build and push of docker images when push occurs to develop, release branches, master but doesn't run any unit test or sonar scanner docker.yml: it will only build for feature branches and Pullrequest is opened, changed , merged (edited)
.github/workflows/docker.yml
Outdated
|
||
on: | ||
push: | ||
branches-ignore: | ||
- "carma-develop" | ||
- "develop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be carma-develp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to carma-develop
.github/workflows/dockerhub.yml
Outdated
|
||
on: | ||
push: | ||
branches: | ||
- "carma-develop" | ||
- "develop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be carma-develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to carma-develop
PR Details
Description
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: