Update cmake for traffic rules to include catkin package command #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Traffic Rules library CMake is the only lanlet2 module that does not include a catkin_package command. This causes issues when including it as a dependency because it generates different cmake config files that often do not work or causes modules that have traffic rules as a dependency create invalid cmake configs.
One example I have seen is that with the current cmake, lanelet2_extension will create a cmake config that looks for a dependent library called lanelet2_traffic_rules::lanelet2_traffic_rules which does not exist, and causes it to throw an error saying:
Related GitHub Issue
Related Jira Key
CDAR-359
Motivation and Context
Fix lanelet2_traffic_rules dependency for building CARMA-Streets service Sensor Data Sharing Service.
How Has This Been Tested?
Locally tested
Types of changes
Checklist: