Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake for traffic rules to include catkin package command #258

Closed

Conversation

paulbourelly999
Copy link

@paulbourelly999 paulbourelly999 commented Dec 5, 2023

PR Details

Description

Traffic Rules library CMake is the only lanlet2 module that does not include a catkin_package command. This causes issues when including it as a dependency because it generates different cmake config files that often do not work or causes modules that have traffic rules as a dependency create invalid cmake configs.

One example I have seen is that with the current cmake, lanelet2_extension will create a cmake config that looks for a dependent library called lanelet2_traffic_rules::lanelet2_traffic_rules which does not exist, and causes it to throw an error saying:

CMake Error at /opt/carma_lanelet2/share/lanelet2_routing/cmake/lanelet2_routingConfig.cmake:173 (message):
  Project 'sensor_data_sharing_service' tried to find library
  'lanelet2_traffic_rules::lanelet2_traffic_rules'.  The library is neither a
  target nor built/installed properly.  Did you compile project
  'lanelet2_routing'? Did you find_package() it before the subdirectory
  containing its code is included?
Call Stack (most recent call first):
  /opt/carma_lanelet2/share/lanelet2_extension/cmake/lanelet2_extensionConfig.cmake:197 (find_package)
  CMakeLists.txt:31 (find_package)

Related GitHub Issue

Related Jira Key

CDAR-359

Motivation and Context

Fix lanelet2_traffic_rules dependency for building CARMA-Streets service Sensor Data Sharing Service.

How Has This Been Tested?

Locally tested

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 changed the base branch from carma-develop to refactor_lanelet2_extension December 5, 2023 05:39
@paulbourelly999 paulbourelly999 marked this pull request as draft December 5, 2023 05:40
@paulbourelly999 paulbourelly999 changed the base branch from refactor_lanelet2_extension to carma-develop December 5, 2023 05:42
@paulbourelly999
Copy link
Author

Replaced by #259. This one was built from incorrect base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant