Fix/green signal issue #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
adamlm
suggested changes
Dec 18, 2023
| @@ -53,6 +53,12 @@ enum class CarmaTrafficSignalState { | |||
| CAUTION_CONFLICTING_TRAFFIC=9 | |||
| }; | |||
|
|
|||
| namespace time{ | |||
|
|
|||
| const int INFINITY_END_TIME_FOR_NOT_ENOUGH_STATES = 2147483647; | |||
There was a problem hiding this comment.
This can be declared constexpr and should use std::numeric_limits (I assume this is indended to be the maximum int value):
constexpr auto INFINITY_END_TIME_FOR_NOT_ENOUGH_STATES{std::numeric_limits<int>::max()};There was a problem hiding this comment.
I think the date is for unix time maximum representable day https://en.wikipedia.org/wiki/Unix_time
There was a problem hiding this comment.
I'm not sure what you mean by this. Can you elaborate?
adamlm
approved these changes
Dec 20, 2023
adamlm
suggested changes
Dec 20, 2023
adamlm
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Supports: usdot-fhwa-stol/carma-platform#2228
Just renaming some constant to make it more explanatory.
Related GitHub Issue
usdot-fhwa-stol/carma-platform#2227
Related Jira Key
CDAR-619
https://usdot-carma.atlassian.net/browse/CDAR-619
Motivation and Context
How Has This Been Tested?
simulation pc 1
Types of changes
Checklist: