Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase hardcoded acceleration limit for simulation #265

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Increase hardcoded acceleration limit for simulation #265

merged 3 commits into from
Mar 5, 2024

Conversation

MishkaMN
Copy link

@MishkaMN MishkaMN commented Mar 4, 2024

PR Details

Description

Increasing the hardcoded acceleration limit so that we can test more range of motion in simulation.

Related GitHub Issue

N/A

Related Jira Key

https://usdot-carma.atlassian.net/browse/CDAR-825

Motivation and Context

vru use case 1 verification testing prep

How Has This Been Tested?

sim pc 1

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN requested a review from JonSmet March 4, 2024 19:24
@MishkaMN MishkaMN self-assigned this Mar 4, 2024
JonSmet
JonSmet requested changes Mar 4, 2024
View reviewed changes
common/hardcoded_params/include/hardcoded_params/control_limits/control_limits.h Outdated
/**
* The maximum allowable simulation parameters
* At the time of writing this, platform uses CARLA 0.9.10 as the vehicle's physics simulator.
* CARLA's this version uses below hardcoded value for its vehicles (so even if increasing this value,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: Maybe change CARLA's this version to CARLA 0.9.10?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited

core_planning/twist_filter/src/twist_filter.cpp Outdated Show resolved Hide resolved
core_planning/twist_filter/src/twist_filter.cpp Outdated Show resolved Hide resolved
core_planning/twist_filter/src/twist_filter.cpp Outdated Show resolved Hide resolved
core_planning/twist_filter/src/twist_filter.cpp Outdated Show resolved Hide resolved
@MishkaMN MishkaMN requested a review from JonSmet March 5, 2024 06:23
@MishkaMN MishkaMN merged commit 8c8675d into release/lavida Mar 5, 2024
2 of 3 checks passed
@MishkaMN MishkaMN deleted the cdar-825-increase-hardcoded-limits branch March 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonSmet JonSmet JonSmet approved these changes

Assignees

@MishkaMN MishkaMN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MishkaMN @JonSmet