Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor drivers/as to ssc-wrapper #273

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

MishkaMN
Copy link

@MishkaMN MishkaMN commented Sep 11, 2024

PR Details

Description

Each vehicle that uses the ROS 1 SSC launches the ROS 1 as package currently in our autoware.ai fork as seen in this line: https://github.com/usdot-fhwa-stol/carma-ssc-interface-wrapper/blob/160367a673dc41[…]b110/ssc_interface_wrapper/launch/remapped_ssc_interface.launch

This PR factors this package to our carma-ssc-interface-wrapper repo

Related GitHub Issue

usdot-fhwa-stol/carma-platform#2079

Related Jira Key

CAR-146

Motivation and Context

Migration to Foxy

How Has This Been Tested?

Checks to see if docker built as package

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN self-assigned this Sep 11, 2024
@MishkaMN MishkaMN added the enhancement New feature or request label Sep 11, 2024
Copy link

@JonSmet JonSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change set looks good!

@MishkaMN
Copy link
Author

Change set looks good, just have to wait to merge until related PR is created in the carma-ssc-interface-wrapper repo and merged.

Related one is merged here usdot-fhwa-stol/carma-ssc-interface-wrapper#161 (comment)

which includes the as package

@MishkaMN MishkaMN merged commit de27b7c into carma-develop Sep 12, 2024
1 of 2 checks passed
@MishkaMN MishkaMN deleted the arc-146-remove-ros1-drivers-as branch September 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants