Address comments for PR #57 #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-du-car
changed the title
| @@ -158,7 +158,9 @@ public void init(ServletConfig oConfig) | |||
| protected void doGet(HttpServletRequest oRequest, HttpServletResponse oResponse) | |||
| throws ServletException, IOException | |||
| { | |||
| long lNow = System.currentTimeMillis(); | |||
| Object timeObj = this.getServletContext().getAttribute(TimeSource.class.getName()); | |||
There was a problem hiding this comment.
I think this should be replaced with the following :
long lNow = TimeSource.getInstance().currentTimeMillis();| @@ -449,7 +451,9 @@ private void addControl(HttpServletRequest oReq, HttpServletResponse oRes) | |||
| { | |||
| try | |||
| { | |||
| long lNow = System.currentTimeMillis() - 10; | |||
| Object timeObj = this.getServletContext().getAttribute(TimeSource.class.getName()); | |||
There was a problem hiding this comment.
long lNow =TimeSource.currentTimeMillis();| @@ -561,7 +565,9 @@ private void saveEdit(HttpServletRequest oReq, HttpServletResponse oRes) | |||
| { | |||
| try | |||
| { | |||
| long lNow = System.currentTimeMillis(); | |||
| Object timeObj = this.getServletContext().getAttribute(TimeSource.class.getName()); | |||
| m_oTs.m_lSimTime = lStep; | ||
| } | ||
| LOGGER.debug(String.format("seq: %d timestep: %d timesource: %d", lSeq, lStep, m_oTs.currentTimeMillis())); | ||
| this.getServletContext().setAttribute(TimeSource.class.getName(), m_oTs); |
There was a problem hiding this comment.
Why do we need to call setAttribute here. We are already setting the value of this member variable.
Also I think we should write a set method for TimeSource which throws an exception when not in simulation mode and maybe a warning when we are setting time backwards. What do you think
| <description>OPTIONAL: Network port for simulation ambassador. Leave undefined for normal time operation.</description> | ||
| <param-name>ambassadorPort</param-name> | ||
| <param-value>1617</param-value> | ||
| </init-param> | ||
|
|
||
| <init-param> | ||
| <description>REQUIRED: Only needed if ambassador address is defined. URL where ambassador sends time sync messages.</description> |
There was a problem hiding this comment.
This is optional now right
|
Changes reflected in #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR is to address some comments left on PR: #57.
Below is the list of comments to be addressed:
Related GitHub Issue
NA
Related Jira Key
NA
Motivation and Context
NA
How Has This Been Tested?
NA
Types of changes
Checklist: