"carma" shell script update to support dual compute system #2189
Conversation
…Improved naming for commands
…riable to main carma.env
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| # Long: Timeout for each service to be detected as available in milliseconds | |||
| # Units: milliseconds | |||
| service_timeout_ms : 200 | |||
| service_timeout_ms : 18000 | |||
There was a problem hiding this comment.
Was this change meant to be committed to develop? 18 seconds seems too large for the timeout
There was a problem hiding this comment.
18000 is a very arbitrary value assigned during testing. This relates to specific Swarm behavior of how it deploys services differently (and a bit slower) than our normal Docker deployment. I can do some testing to see what this value actually needs to be, it should be lower but unsure by how much. I can show you a demo sometime as an example.
| declare_system_architecture = DeclareLaunchArgument( | ||
| name = 'system_architecture', | ||
| default_value = 'single', | ||
| description = 'Flag to define whether a single compute system or a dual compute system is being used' |
There was a problem hiding this comment.
Can you also specify the accepted values for this config in the description?
There was a problem hiding this comment.
Technically the accepted values are shown in both of these but I can see how it's not clear. It'd be better to be bolded but can't have that, do you think putting it as 'single' 'dual' / 'manager' 'worker' with single quotes in the text be clear enough?
There was a problem hiding this comment.
Yes, i think having them in single quotes would make it clear that those are the values we can use here
| declare_host_placement = DeclareLaunchArgument( | ||
| name = 'host_placement', | ||
| default_value = 'manager', | ||
| description = 'Flag to define whether the current active host is a manager or worker for ROS node allocation' |
There was a problem hiding this comment.
Same as above, can you define the accepted values for the config in the description?
|
@willjohnsonk Should we close this PR if it is not getting merged? |
PR Details
Description
To support dual compute system design the carma shell script should be updated so that it can manage Docker services and containers across two PCs. All management of the system should be done from a single manager PC called "PC1", which will run commands similar to "carma start" and other carma commands.
Related GitHub Issue
Related Jira Key
Motivation and Context
Improvements will allow for higher computation throughput on systems by leveraging two PCs.
How Has This Been Tested?
Carma bash script has run successfully on dual compute hardware.
Types of changes
Checklist: