more processes #2469
Open
more processes #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| "node", | ||
| "rviz", | ||
| "rqt", | ||
| "ros2 launch", |
There was a problem hiding this comment.
Nit: Shouldn't need ros2 launch since ros2 is already a keyword
| cmdline_lower = cmdline.lower() | ||
|
|
||
| # Check exclusions first | ||
| if any(excl in name_lower or excl in cmdline_lower for excl in EXCLUDE_KEYWORDS): |
There was a problem hiding this comment.
If there is an excluded keyword in the process and also a ROS keyword this would still return false, is that the desired behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Previously in #2467, cpu usage script was merged.
It captured only few keywords.
This PR updates the code to capture the keywords more elegantly and few more keywords as well.
With this the usage shows slightly higher; hence, slightly accurate. However, it didn't increase that much significantly which makes sense.
Related GitHub Issue
NA
Related Jira Key
https://usdot-carma.atlassian.net/browse/ARC-255
Motivation and Context
Discovered during creating plot for the usage.
How Has This Been Tested?
Tested on CDASIM run
Before:
After (memory usage went down because I closed several orphan rviz windows. And the bump in the end is extra scripts running to save logs that we used in CP VRU use case):
Types of changes
Checklist: