Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo #160

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Sep 9, 2024

PR Details

Description

This PR supports removal of unused ROS1 code from carma-utils as most of the code is migrated to ROS2 foxy.
This PR: usdot-fhwa-stol/carma-utils#234

Added from carma-utils to here:
cav_driver_utils is used by ros1 drivers, but all of them are deprecated except the ssc driver. Therefore it was also moved to ssc wrapper repo along with socketcan_bridge
socketcan_bridge and socketcan_interface is used by pacifica's dbw controller, so factored into that repo here.

This PR also attempts to fix the Circle CI failure for ROS1 package builds.

Related GitHub Issue

usdot-fhwa-stol/carma-platform#2079

Related Jira Key

ARC-146

Motivation and Context

Migration to Foxy

How Has This Been Tested?

Built carma-platform on local VM

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN changed the title Factor packages from carma-utils for ssc wrapper Factor packages from carma-utils to ssc wrapper repo Sep 9, 2024
@MishkaMN MishkaMN requested a review from adev4a September 9, 2024 15:16
@MishkaMN MishkaMN marked this pull request as draft September 9, 2024 15:17
@MishkaMN MishkaMN self-assigned this Sep 9, 2024
@MishkaMN MishkaMN removed the request for review from adev4a September 9, 2024 15:17
@MishkaMN MishkaMN changed the title Factor packages from carma-utils to ssc wrapper repo Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo Sep 9, 2024
@MishkaMN MishkaMN changed the title Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo [WIP] Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant