-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo #160
Draft
MishkaMN
wants to merge
20
commits into
develop
Choose a base branch
from
arc-146-remove-ros1
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaMN
changed the title
Factor packages from carma-utils for ssc wrapper
Factor packages from carma-utils to ssc wrapper repo
Sep 9, 2024
MishkaMN
changed the title
Factor packages from carma-utils to ssc wrapper repo
Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo
Sep 9, 2024
MishkaMN
changed the title
Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo
[WIP] Fix Circle CI & Factor packages from carma-utils to ssc wrapper repo
Sep 9, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR supports removal of unused ROS1 code from carma-utils as most of the code is migrated to ROS2 foxy.
This PR: usdot-fhwa-stol/carma-utils#234
Added from carma-utils to here:
cav_driver_utils is used by ros1 drivers, but all of them are deprecated except the ssc driver. Therefore it was also moved to ssc wrapper repo along with socketcan_bridge
socketcan_bridge and socketcan_interface is used by pacifica's dbw controller, so factored into that repo here.
This PR also attempts to fix the Circle CI failure for ROS1 package builds.
Related GitHub Issue
usdot-fhwa-stol/carma-platform#2079
Related Jira Key
ARC-146
Motivation and Context
Migration to Foxy
How Has This Been Tested?
Built carma-platform on local VM
Types of changes
Checklist: