Merge release/lavida (4.5.0) branch into master #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initialize carma-clock at time 0 to avoid wait_for_initialization bug in carma-time-lib. Also added more debug logging for SNMP commands. * Added comment * Added logic for gtest that is compatible with CMake version 3.20 above and below * Fixed Message Services docker build * Fix signal opt service docker build
* init * add unit test * update clear * update data type * update service * update * update dockerfile * fix sonarscan * fix sonarscan * update coverage * update coverage * update unit test * update log * address code coverage * update code coverage * update topic * add more coverage * address code smell * add more code coverage * update * address comments * update readme * update code coverage * add coverage * update readme
* init * update lib * update * update tsc service * update queue * update build * update unit test * update tsc service * update coverage * update * update * update * update code coverage and refactor create omit cmd func * update code coverage * add test script * fix concurrent queue update * update * address comments * address comments * add readme * address comments * address comments * address comments * add break * update * update * update * add more comments
* init * update coverage * update * update * update unit test * correct readme * correct readme * add more unit test
* Adding devcontainer setup and logging for vehicle/ped calls * Removed dev container setup * Added Unit tests and CSV logger * Update * Updates * Fix rapidjson lib naming bug introduced by (Tencent/rapidjson#1901 * Fix rapidjson * Updated ci to remove light clone * Update to resolve build issues * Updated Map calls from [] operator to at to make methods constant Fixed bug in streets_service_base create_daily_logger * Fixed bug * Added unit testing * Added unit tests for streets_service_base create_daily_logger * Added unit test converage for configure logger methods Update methods to be const due to sonar code smells * Updated test cases * Added javadoc comments include default values for daily_logger update unit tests * PR Updates * Added translation for enumeration * Add unit test for spat_enum
+ Added line to get ubuntu distrib codename + stol apt debian packages push to s3 path base on codename
* Fix/cleanup tsc_service implementation + Add logging to streets service base clock singleton to indicate when thread is waiting on carma-clock initialization + Comment out MRP TSC Service integration which may no longer be necessary + Update SPAT_PROJECTION_ENUM to be capital + Modify unit tests to confirm carma-clock lib supports notifying multiple threads waiting on initialization + Update intall_dependecies.sh to pull carma-clock stol debian from correct repository in s3 bucket according to ubuntu distribution * Revert apt-get carma-time-lib changes, which will be in another PR * Updated unit tests and test documentation * Removed log statement
* Update third party to releases + Fix message services and intersection model build issues * Remove redudant gtest install
* Adding working directory to allow for relative path creation of log file * Included comment
* CDAR-751:Convert detections from assumed ENU to SDSM NED coordinate frame * Updated documentation * Add method documentation * Update comments * Added license header comment * Peer Review comments Removed intermediate variables Using EXPECT_DOUBLE_EQ and EXPECT_NEAR * Updates * Add comment
* CDAR-756: Skip detection data with large delay * Fix compilation errors * Added logging * Updates
* CDAR-790:Fix kafka data collection script + update script to consume data from new topics * Update docker-compose with health-check Update collection script * Update collect service logs script and include documentation * Updates * Shell check updates * Fix errors * Fix failing unit test * Address sonar code smells * Replace os zip and rm calls with shutil * Use Pathlib instead of os for mkdir and file checks * Fix type
* CDA-819: Add timestamp information to detection data in SDSM * Correct message timestamp member name * Fix unit tests * Fix syntax errors * Address sonar code smell * Remove const from primitive parameter pass by value * Updates * Fix syntax error
* add time sync log * move to debug * add comment
* Update unit test to expect 0 detections since incoming detection is not up to date * Fix typo
* Include CI badge for Sensor Data Sharing Service * Fix typo
* Update to release target versions * Update sensor_data_sharing_service base image * Sensor Data Sharing Service changes
MishkaMN
previously approved these changes
Apr 8, 2024
MishkaMN
reviewed
Apr 9, 2024
MishkaMN
reviewed
Apr 9, 2024
MishkaMN
reviewed
Apr 9, 2024
.github/workflows/develop_master.yml
Outdated
| shell: bash | ||
| runs-on: ubuntu-latest-8-cores | ||
| container: | ||
| image: usdotfhwastoldev/streets_service_base_lanelet_aware:bionic |
There was a problem hiding this comment.
Do we need to change org here too?
MishkaMN
reviewed
Apr 9, 2024
* Fix CI for master * Testing * Undo testing changes
MishkaMN
previously approved these changes
Apr 9, 2024
9 tasks
* Added workflows for release and master builds for base imags * Update release workflow name
MishkaMN
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Need #416 to be merged before this PR is merged
Related GitHub Issue
Related Jira Key
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: